Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unskip test now that input_extensions is no more #1187

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

aborgna-q
Copy link
Collaborator

Removes the conditional test skip introduced in #1168 (comment), now that #1142 is merged.

@aborgna-q aborgna-q requested a review from acl-cqc June 12, 2024 14:22
@aborgna-q aborgna-q requested a review from a team as a code owner June 12, 2024 14:22
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (ea5213d) to head (52a2cd9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1187   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files          94       94           
  Lines       17659    17659           
  Branches    16797    16797           
=======================================
  Hits        15289    15289           
  Misses       1600     1600           
  Partials      770      770           
Flag Coverage Δ
rust 86.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aborgna-q aborgna-q added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit cbe31be Jun 14, 2024
20 checks passed
@aborgna-q aborgna-q deleted the ab/unskip-test branch June 14, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants